From aa5c7fc159b0f5175ede96d46b8d2a2669a176a4 Mon Sep 17 00:00:00 2001 From: Florian Fischer Date: Wed, 28 Dec 2022 13:27:05 +0100 Subject: llog: use variable argument list Mirror more closely the fmt interface and reduce the verbosity of the log call sites. Additionally the log message is only created if we are actually going to log it. --- localBackend.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'localBackend.go') diff --git a/localBackend.go b/localBackend.go index a09d9a1..2dbd4fd 100644 --- a/localBackend.go +++ b/localBackend.go @@ -1,14 +1,14 @@ package main import ( - "fmt" - "github.com/dhowden/tag" - "muhq.space/go/wrms/llog" "os" "path" "path/filepath" "strings" "sync" + + "github.com/dhowden/tag" + "muhq.space/go/wrms/llog" ) type LocalBackend struct { @@ -31,7 +31,7 @@ func (b *LocalBackend) insert(song *Song) { } func (b *LocalBackend) findSongs() { - llog.Debug(fmt.Sprintf("Starting song search under: %s", b.musicDir)) + llog.Debug("Starting song search under: %s", b.musicDir) // Insert some Songs song := NewSong("No!", "Bukahara", "local", "Bukahara/Phantasma/01-No!.ogg") @@ -42,7 +42,7 @@ func (b *LocalBackend) findSongs() { err := filepath.Walk(b.musicDir, func(p string, finfo os.FileInfo, err error) error { if err != nil { - llog.Warning(fmt.Sprintf("error %v at path %s\n", err, p)) + llog.Warning("error %v at path %s\n", err, p) return err } @@ -60,13 +60,13 @@ func (b *LocalBackend) findSongs() { f, err := os.Open(p) defer f.Close() if err != nil { - llog.Warning(fmt.Sprintf("error %v opening file %s", err, p)) + llog.Warning("error %v opening file %s", err, p) return err } m, err := tag.ReadFrom(f) if err != nil { - llog.Warning(fmt.Sprintf("error reading tags from %s: %v", p, err)) + llog.Warning("error reading tags from %s: %v", p, err) // Contiune walking return nil } @@ -77,7 +77,7 @@ func (b *LocalBackend) findSongs() { }) if err != nil { - llog.Error(fmt.Sprintf("error walking the path %q: %v", b.musicDir, err)) + llog.Error("error walking the path %q: %v", b.musicDir, err) } } -- cgit v1.2.3