From 6decfb1935a95cea07bceeec5de26eb5a47472d5 Mon Sep 17 00:00:00 2001
From: Florian Fischer <florian.fischer@muhq.space>
Date: Thu, 1 Jun 2023 14:08:56 +0200
Subject: send events in a total order

Move Connection code to wmrs.go. Introduce a RWMutex to synchronize
access to the internal Wrms state. Tag each event when it is broadcast
with the next event count. Senders will order the broadcasted events.
This guarantees that no obsoltete events are ever delivered.
---
 main.go | 102 +++++++---------------------------------------------------------
 1 file changed, 11 insertions(+), 91 deletions(-)

(limited to 'main.go')

diff --git a/main.go b/main.go
index 532cead..0ea10dd 100644
--- a/main.go
+++ b/main.go
@@ -2,7 +2,6 @@ package main
 
 import (
 	"context"
-	"encoding/json"
 	"flag"
 	"fmt"
 	"html/template"
@@ -190,114 +189,35 @@ func nextHandler(w http.ResponseWriter, r *http.Request) {
 }
 
 func wsEndpoint(w http.ResponseWriter, r *http.Request) {
-	c, err := websocket.Accept(w, r, nil)
-	if err != nil {
-		llog.Warning("Accepting the websocket failed with %s", err)
-		return
-	}
-
-	uuidCookie, err := r.Cookie("UUID")
+	connId, err := getConnId(w, r)
 	if err != nil {
-		llog.Error("websocket connection has no set UUID cookie")
-		http.Error(w, "websocket connection has no set UUID cookie", http.StatusBadRequest)
 		return
 	}
 
-	id, err := uuid.Parse(uuidCookie.Value)
+	ws, err := websocket.Accept(w, r, nil)
 	if err != nil {
-		llog.Error("Invalid UUID set in cookie")
-		http.Error(w, "Invalid UUID set in cookie", http.StatusBadRequest)
+		llog.Warning("Accepting the websocket failed with %s", err)
 		return
 	}
 
 	ctx, cancel := context.WithCancel(r.Context())
-	ctx = c.CloseRead(ctx)
+	ctx = ws.CloseRead(ctx)
 
 	defer func() {
-		llog.Info("cancel context of connection %v", id)
+		llog.Info("cancel context of connection %v", connId)
 		cancel()
 	}()
 
-	conn := newConnection(id, c)
-	wrms.addConn(conn)
+	conn := newConnection(connId, ws, ctx, cancel)
 	defer conn.Close()
 
-	llog.Info("New websocket connection with id %v", id)
-
-	initialCmds := [][]byte{}
-	if wrms.Playing {
-		var songs []Song
-		if currentSong := wrms.CurrentSong.Load(); currentSong != nil {
-			songs = []Song{*currentSong}
-		}
-		data, err := json.Marshal(wrms.newEvent("play", songs))
-		if err != nil {
-			llog.Error("Encoding the play event failed with %s", err)
-			return
-		}
-		initialCmds = append(initialCmds, data)
-	}
-
-	upvoted := []Song{}
-	downvoted := []Song{}
-	if len(wrms.Songs) > 0 {
-		data, err := json.Marshal(wrms.newEvent("add", wrms.Songs))
-		if err != nil {
-			llog.Error("Encoding the add event failed with %s", err)
-			return
-		}
-		initialCmds = append(initialCmds, data)
-
-		for _, song := range wrms.Songs {
-			if _, ok := song.Upvotes[id]; ok {
-				upvoted = append(upvoted, song)
-			} else if _, ok := song.Downvotes[id]; ok {
-				downvoted = append(downvoted, song)
-			}
-		}
-	}
-
-	if len(upvoted) > 0 {
-		data, err := json.Marshal(wrms.newEvent("upvoted", upvoted))
-		if err != nil {
-			llog.Error("Encoding the upvoted event failed with %s", err)
-			return
-		}
-		initialCmds = append(initialCmds, data)
-	}
-
-	if len(downvoted) > 0 {
-		data, err := json.Marshal(wrms.newEvent("downvoted", downvoted))
-		if err != nil {
-			llog.Error("Encoding the upvoted event failed with %s", err)
-			return
-		}
-		initialCmds = append(initialCmds, data)
-	}
-
-	for _, data := range initialCmds {
-		llog.Info("Sending initial cmd %s", string(data))
-		err = c.Write(ctx, websocket.MessageText, data)
-		if err != nil {
-			llog.Warning("Sending the initial commands failed with %s", err)
-			return
-		}
+	llog.Info("New websocket connection with id %v", connId)
+	err = wrms.initConn(conn)
+	if err != nil {
+		return
 	}
 
-	for ev := range conn.Events {
-		data, err := json.Marshal(ev)
-		if err != nil {
-			llog.Error("Encoding the %s event failed with %s", ev.Event, err)
-			return
-		}
-
-		llog.Debug("Sending ev %s to %s", string(data), id)
-		err = c.Write(ctx, websocket.MessageText, data)
-		if err != nil {
-			llog.Warning("Sending the ev %s to %d failed with %s", string(data), id, err)
-			return
-		}
-	}
+	conn.serve()
 }
 
 func setupRoutes() {
-- 
cgit v1.2.3