From aa5c7fc159b0f5175ede96d46b8d2a2669a176a4 Mon Sep 17 00:00:00 2001 From: Florian Fischer Date: Wed, 28 Dec 2022 13:27:05 +0100 Subject: llog: use variable argument list Mirror more closely the fmt interface and reduce the verbosity of the log call sites. Additionally the log message is only created if we are actually going to log it. --- playlist.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'playlist.go') diff --git a/playlist.go b/playlist.go index c5fa9e1..249bad5 100644 --- a/playlist.go +++ b/playlist.go @@ -2,7 +2,6 @@ package main import ( "container/heap" - "fmt" "muhq.space/go/wrms/llog" ) @@ -38,22 +37,22 @@ func (pl *Playlist) Pop() any { } func (pl *Playlist) PopSong() *Song { - llog.DDebug(fmt.Sprintf("popping song from the playlist (%p) -> %v", pl, pl)) + llog.DDebug("popping song from the playlist (%p) -> %v", pl, pl) if len(*pl) == 0 { return nil } s := heap.Pop(pl).(*Song) - llog.DDebug(fmt.Sprintf("popped song %p from the playlist (%p) -> %v", s, pl, pl)) + llog.DDebug("popped song %p from the playlist (%p) -> %v", s, pl, pl) return s } func (pl *Playlist) Add(s *Song) { heap.Push(pl, s) - llog.DDebug(fmt.Sprintf("added song %p to the playlist (%p) -> %v", s, pl, pl)) + llog.DDebug("added song %p to the playlist (%p) -> %v", s, pl, pl) } func (pl *Playlist) Adjust(s *Song) { heap.Fix(pl, s.index) - llog.DDebug(fmt.Sprintf("adjusting song %p in the playlist (%p) -> %v", s, pl, pl)) + llog.DDebug("adjusting song %p in the playlist (%p) -> %v", s, pl, pl) } -- cgit v1.2.3