From 84374b4b4e41c4bb7896092c10098b5e6b5f68c1 Mon Sep 17 00:00:00 2001 From: Florian Fischer Date: Wed, 11 Sep 2019 17:59:23 +0200 Subject: explicitly collect binary versions There is no generic way to retrieve the version of a binary. Not everyone followes GNU cli guidelines and supports "--version". The larson benchmark for example reads input from stdin when started with "larson --version" blocking the Benchmark.prepare() call. --- src/benchmark.py | 1 - 1 file changed, 1 deletion(-) (limited to 'src/benchmark.py') diff --git a/src/benchmark.py b/src/benchmark.py index f9b4dfd..df31068 100644 --- a/src/benchmark.py +++ b/src/benchmark.py @@ -193,7 +193,6 @@ class Benchmark: exe = src.util.find_cmd(r) if exe is not None: self.results["facts"]["libcs"][r] = src.facter.libc_ver(executable=exe) - self.results["facts"]["versions"][r] = src.facter.exec_ver(exe) else: raise Exception("Requirement: {} not found".format(r)) -- cgit v1.2.3