From 5f6c52dff03f2dc85d5b26b7f4469bc85a25ee09 Mon Sep 17 00:00:00 2001 From: Florian Fischer Date: Fri, 13 Dec 2019 14:43:54 +0100 Subject: introduce verbosity aware subprocess.run wrapper and use it in benchmarks --- src/benchmarks/redis.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'src/benchmarks/redis.py') diff --git a/src/benchmarks/redis.py b/src/benchmarks/redis.py index b487baf..23c2de6 100644 --- a/src/benchmarks/redis.py +++ b/src/benchmarks/redis.py @@ -23,13 +23,12 @@ archive. The used parameters are inspired by the ones used in mimalloc-bench." import os import re -import subprocess import sys from urllib.request import urlretrieve from src.artifact import ArchiveArtifact from src.benchmark import Benchmark -from src.util import print_info +from src.util import print_info, run_cmd REQUESTS_RE = re.compile("(?P(\\d*.\\d*)) requests per second") @@ -63,10 +62,7 @@ class BenchmarkRedis(Benchmark): redis.provide(self.build_dir) # building redis - proc = subprocess.run( - ["make", "-C", redis_dir, "MALLOC=libc", "USE_JEMALLOC=no"], - # stdout=subprocess.PIPE, stderr=subprocess.PIPE, - universal_newlines=True) + run_cmd(["make", "-C", redis_dir, "MALLOC=libc", "USE_JEMALLOC=no"]) # create symlinks for exe in ["redis-cli", "redis-server", "redis-benchmark"]: -- cgit v1.2.3