From 84374b4b4e41c4bb7896092c10098b5e6b5f68c1 Mon Sep 17 00:00:00 2001 From: Florian Fischer Date: Wed, 11 Sep 2019 17:59:23 +0200 Subject: explicitly collect binary versions There is no generic way to retrieve the version of a binary. Not everyone followes GNU cli guidelines and supports "--version". The larson benchmark for example reads input from stdin when started with "larson --version" blocking the Benchmark.prepare() call. --- src/benchmarks/redis.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/benchmarks/redis.py') diff --git a/src/benchmarks/redis.py b/src/benchmarks/redis.py index 689a9b6..0afddba 100644 --- a/src/benchmarks/redis.py +++ b/src/benchmarks/redis.py @@ -55,6 +55,8 @@ class BenchmarkRedis(Benchmark): redis_url = f"http://download.redis.io/releases/{redis_archive}" redis_dir = os.path.join(self.build_dir, f"redis-{redis_version}") + self.results["facts"]["versions"]["redis"] = redis_version + if not os.path.isdir(redis_dir): if not os.path.isfile(redis_archive): print(f"Downloading redis-{redis_version}...") -- cgit v1.2.3