From 2ee42003433b2faeda4ded1bc6557a6eaf3720ff Mon Sep 17 00:00:00 2001
From: Florian Fischer <florian.fischer@muhq.space>
Date: Sat, 28 Dec 2024 11:38:44 +0100
Subject: improve code

* explicitly ignore errors where appropriate
* do not append in a loop
* specify format string in Errorf
---
 go/game/trigger.go | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

(limited to 'go/game/trigger.go')

diff --git a/go/game/trigger.go b/go/game/trigger.go
index eb0cc424..2619bdd8 100644
--- a/go/game/trigger.go
+++ b/go/game/trigger.go
@@ -75,9 +75,7 @@ func newEotEvent() Event {
 func newTargetEvent(source interface{}, targets *Targets) Event {
 	affected := make([]interface{}, 0, len(targets.ts))
 	for _, t := range targets.ts {
-		for _, sel := range t.sel {
-			affected = append(affected, sel)
-		}
+		affected = append(affected, t.sel...)
 	}
 	return Event{eventType: target, sources: []interface{}{source}, affected: affected}
 }
@@ -109,7 +107,6 @@ func (t *triggerBase) Card() *Card {
 		log.Panicf("Unhandled source type %v", t)
 		return nil
 	}
-	return nil
 }
 
 func (t *triggerBase) trigger(s *LocalState, e Event) ([]*TriggeredAction, bool) {
-- 
cgit v1.2.3