From 89cf7c5c14becb6ebfc682932dadf1e5697b2675 Mon Sep 17 00:00:00 2001
From: Florian Fischer <florian.fischer@muhq.space>
Date: Mon, 17 Jul 2023 22:28:53 +0200
Subject: build the command arrays directly without string splitting

---
 quiz.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/quiz.py b/quiz.py
index b7bad61..d6c6a21 100755
--- a/quiz.py
+++ b/quiz.py
@@ -43,7 +43,8 @@ def err(msg: str, status=1):
 
 def play_sound(sound: Path):
     """Play a sound file"""
-    subprocess.run(f'{PLAY_SOUND_CMD} "{sound}"'.split(),
+    cmd = PLAY_SOUND_CMD.split() + [str(sound)]
+    subprocess.run(cmd,
                    check=True,
                    stderr=subprocess.DEVNULL,
                    stdout=subprocess.DEVNULL)
@@ -147,7 +148,7 @@ def load_solutions(question_dirs: list[Path],
 
 def show_question(question: Path) -> subprocess.Popen:
     """show the question in an external programm and return the process"""
-    cmd = f'{SHOW_QUESTION_CMD} "{question}"'.split()
+    cmd = SHOW_QUESTION_CMD.split() + [str(question)]
     return subprocess.Popen(cmd, shell=True)
 
 
-- 
cgit v1.2.3