diff options
Diffstat (limited to 'src/mass-graduation.js')
| -rw-r--r-- | src/mass-graduation.js | 27 |
1 files changed, 13 insertions, 14 deletions
diff --git a/src/mass-graduation.js b/src/mass-graduation.js index 3cbf32a..0a69cd1 100644 --- a/src/mass-graduation.js +++ b/src/mass-graduation.js @@ -113,7 +113,7 @@ function observationClickHandler(li) { async function loadGroup(selected) { group = selected; const students = await group.getStudents(); - let graduationPromises = []; + const graduationPromises = []; document.getElementById("group-content").style.display = "block"; const ul = document.getElementById("group-members"); @@ -124,30 +124,30 @@ async function loadGroup(selected) { const graduationPromise = student.getGraduation(); const li = document.createElement("li"); - li.classList.add("group-member") + li.classList.add("group-member"); // Remember the student of the entry li.student = student; const i = document.createElement("img"); - i.classList.add("group-member-icon") + i.classList.add("group-member-icon"); graduationPromise.then((graduation) => { i.src = graduation.getIcon(); }); li.appendChild(i); const n = document.createElement("span"); - n.classList.add("group-member-name") + n.classList.add("group-member-name"); n.innerHTML = `${student.name}`; li.appendChild(n); const ob = document.createElement("button"); - ob.classList.add("group-member-observation-icon") + ob.classList.add("group-member-observation-icon"); graduationPromise.then((graduation) => { if (!graduation.isObserved()) { return; } - ob.innerHTML = "👁" + ob.innerHTML = "👁"; ob.addEventListener("click", () => observationClickHandler(li) ); }); graduationPromises.push(graduationPromise); @@ -156,7 +156,7 @@ async function loadGroup(selected) { for (const col of ["green", "orange", "red"]) { const b = document.createElement("button"); - b.classList.add(`group-member-${col}`) + b.classList.add(`group-member-${col}`); b.innerHTML = "o"; b.addEventListener("click", () => toggle(b) ); li.appendChild(b); @@ -167,7 +167,7 @@ async function loadGroup(selected) { li.appendChild(textarea); const p = document.createElement("button"); - p.classList.add("group-member-print") + p.classList.add("group-member-print"); p.innerHTML = "🖶"; p.addEventListener("click", () => printNote(li) ); li.appendChild(p); @@ -176,7 +176,7 @@ async function loadGroup(selected) { } const graduations = await Promise.all(graduationPromises); - let observations = graduations.filter( + const observations = graduations.filter( (g) => g.observationRequested || (g.observation && !g.observation.end) ); @@ -192,9 +192,8 @@ async function loadGroup(selected) { const observationReuqestsNode = document.getElementById("observation-requests"); observationReuqestsNode.innerHTML = ""; observations.sort((g1, g2) => { - let g1D, g2D; - g1D = g1.observationRequested ? g1.observationRequested : g1.observation.start; - g2D = g2.observationRequested ? g2.observationRequested : g2.observation.start; + const g1D = g1.observationRequested ? g1.observationRequested : g1.observation.start; + const g2D = g2.observationRequested ? g2.observationRequested : g2.observation.start; return g1D - g2D; }); @@ -256,7 +255,7 @@ function submitMassGraduation() { // TODO(muhq): await graduation promises - let promises = []; + const promises = []; for(const li of document.querySelectorAll("li.group-member")) { const reason = li.querySelector(".group-member-point-reason").value; const student = li.student; @@ -270,7 +269,7 @@ function submitMassGraduation() { promises.push(submitGraduationChange(student, GraduationChange.newRedPointChange(reason, name))); } if (li.observationDiv) { - let status = []; + const status = []; for (const row of li.observationDiv.querySelectorAll("tbody > tr")) { if (row.querySelector('td[data-yes="true"]').innerHTML === "X") status.push("yes"); |